Fix incorrect v8 TryCatch.

Fix incorrect v8 TryCatch.

The Try-Catch object must live the whole lexical scope.
Without the giving a name to the object, this is equivalent to create a temporary that is destroy at the end of the statement.

/src/pdfium/pdfium/out/Debug/../../fpdfsdk/javascript/JS_Value.cpp:154:3: warning: object destroyed immediately after creation; did you mean to name the object? [misc-unused-raii]

This issue was found by clang-tidy

R=dsinclair
BUG=589955
Committed: https://pdfium.googlesource.com/pdfium/+/b2f6f9158f54cee1825830c7ed57fe9d89cff26e

[dsinclair, 2016-04-27 15:46:47]

dsinclair@chromium.org changed reviewers:
+ jochen@chromium.org

[dsinclair, 2016-04-27 15:46:48]

This seems fine to me, from the code I'm guessing we don't care if the object
lives because it's already serves its purpose.

jochen@ is this fine from a V8 perspective?

[jochen (gone - plz use gerrit), 2016-04-27 15:51:11]

lgtm

[dsinclair, 2016-04-27 15:52:13]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-27 15:52:14]

lgtm

[commit-bot: I haz the power, 2016-04-27 15:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929513002/1

[commit-bot: I haz the power, 2016-04-27 16:10:14]

Description was changed from

==========
Fix incorrect v8 TryCatch.

The Try-Catch object must live the whole lexical scope.
Without the giving a name to the object, this is equivalent to create a
temporary that is destroy at the end of the statement.

/src/pdfium/pdfium/out/Debug/../../fpdfsdk/javascript/JS_Value.cpp:154:3:
warning: object destroyed immediately after creation; did you mean to name the
object? [misc-unused-raii]

This issue was found by clang-tidy

R=dsinclair
BUG=589955
==========

to

==========
Fix incorrect v8 TryCatch.

The Try-Catch object must live the whole lexical scope.
Without the giving a name to the object, this is equivalent to create a
temporary that is destroy at the end of the statement.

/src/pdfium/pdfium/out/Debug/../../fpdfsdk/javascript/JS_Value.cpp:154:3:
warning: object destroyed immediately after creation; did you mean to name the
object? [misc-unused-raii]

This issue was found by clang-tidy

R=dsinclair
BUG=589955

Committed:
https://pdfium.googlesource.com/pdfium/+/b2f6f9158f54cee1825830c7ed57fe9d89cf...
==========

[commit-bot: I haz the power, 2016-04-27 16:10:15]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b2f6f9158f54cee1825830c7ed57fe9d89cf...