fpdfsdk/javascript/JS_Value.cpp - Issue 1929513002: Fix incorrect v8 TryCatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Value.cpp

Issue 1929513002: Fix incorrect v8 TryCatch. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_Value.cpp

diff --git a/fpdfsdk/javascript/JS_Value.cpp b/fpdfsdk/javascript/JS_Value.cpp

index e2c990c51ccb477a72dab424bb3dcdab853e6689..ab02f02cfb0250e0b6b6cd6aef096490a8a3092c 100644

--- a/fpdfsdk/javascript/JS_Value.cpp

+++ b/fpdfsdk/javascript/JS_Value.cpp

@@ -151,7 +151,7 @@ void CJS_Value::MaybeCoerceToNumber() {

if (bstr == "NaN")

bAllowNaN = true;

}

- v8::TryCatch(m_pJSRuntime->GetIsolate());

+ v8::TryCatch try_catch(m_pJSRuntime->GetIsolate());

v8::MaybeLocal<v8::Number> maybeNum =

m_pValue->ToNumber(m_pJSRuntime->GetIsolate()->GetCurrentContext());

if (maybeNum.IsEmpty())

« no previous file with comments | « no previous file | no next file » | no next file with comments »