Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1929413002: Don't include contents visual overflow into paint invalidation rect (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include contents visual overflow into paint invalidation rect Now we always invalidate any object needing repaint, so we never need the paint invalidation rect of an ancestor to cover descendants. BUG=436198 Committed: https://crrev.com/638c1a24dc8fdcceb5b5f4acd9d03d3a09b9cfa3 Cr-Commit-Position: refs/heads/master@{#392652}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : NeedsRebaseline #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -82 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 2 chunks +80 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/spv2/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/OverflowModel.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/OverflowModelTest.cpp View 2 chunks +101 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Xianzhu
4 years, 7 months ago (2016-05-09 19:10:39 UTC) #3
chrishtr
lgtm
4 years, 7 months ago (2016-05-09 21:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929413002/60001
4 years, 7 months ago (2016-05-10 03:40:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/226057)
4 years, 7 months ago (2016-05-10 04:47:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929413002/80001
4 years, 7 months ago (2016-05-10 16:48:51 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-10 18:21:41 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/638c1a24dc8fdcceb5b5f4acd9d03d3a09b9cfa3 Cr-Commit-Position: refs/heads/master@{#392652}
4 years, 7 months ago (2016-05-10 18:23:28 UTC) #16
Zhenyao Mo
4 years, 7 months ago (2016-05-12 17:15:28 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1973023002/ by zmo@chromium.org.

The reason for reverting is: caused rendering regression, see crbug.com/611272.

Powered by Google App Engine
This is Rietveld 408576698