third_party/WebKit/Source/core/layout/OverflowModel.h - Issue 1929413002: Don't include contents visual overflow into paint invalidation rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/OverflowModel.h

Issue 1929413002: Don't include contents visual overflow into paint invalidation rect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | third_party/WebKit/Source/core/layout/OverflowModelTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/OverflowModel.h

diff --git a/third_party/WebKit/Source/core/layout/OverflowModel.h b/third_party/WebKit/Source/core/layout/OverflowModel.h

index 318fbfb947b46a8b596c29c84495c5e241fedbe7..f8640adf64833349bbc852e58b02dd9b0a5c7a39 100644

--- a/third_party/WebKit/Source/core/layout/OverflowModel.h

+++ b/third_party/WebKit/Source/core/layout/OverflowModel.h

@@ -94,8 +94,7 @@ public:

const LayoutRect& visualOverflowRect() const { return m_visualOverflow; }

void setVisualOverflow(const LayoutRect& rect) { m_visualOverflow = rect; }

- // TODO(wangxianzhu): Should use normal LayoutRect::unite() which ignores empty rects.

- void addVisualOverflow(const LayoutRect& rect) { m_visualOverflow.uniteEvenIfEmpty(rect); }

+ void addVisualOverflow(const LayoutRect& rect) { m_visualOverflow.unite(rect); }

void move(LayoutUnit dx, LayoutUnit dy)

{

@@ -148,8 +147,7 @@ public:

void addLayoutOverflow(const LayoutRect& rect) { uniteLayoutOverflowRect(m_layoutOverflow, rect); }

const LayoutRect& selfVisualOverflowRect() const { return m_selfVisualOverflow; }

- // TODO(wangxianzhu): Should use normal LayoutRect::unite() which ignores empty rects.

- void addSelfVisualOverflow(const LayoutRect& rect) { m_selfVisualOverflow.uniteEvenIfEmpty(rect); }

+ void addSelfVisualOverflow(const LayoutRect& rect) { m_selfVisualOverflow.unite(rect); }

const LayoutRect& contentsVisualOverflowRect() const { return m_contentsVisualOverflow; }

void addContentsVisualOverflow(const LayoutRect& rect) { m_contentsVisualOverflow.unite(rect); }