Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1929203004: Rename gfx::Display/Screen to display::Display/Screen in views mac (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in views mac BUG=597761 TBR=sky@chromium.org Committed: https://crrev.com/53682f2ee583aa28ba4e4721efbf28d8e2e59459 Cr-Commit-Position: refs/heads/master@{#390787}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/views/cocoa/bridged_native_widget.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/event_monitor_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
oshima
4 years, 7 months ago (2016-04-29 18:09:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929203004/1
4 years, 7 months ago (2016-04-29 18:09:24 UTC) #4
oshima
On 2016/04/29 18:09:07, oshima wrote: Oops, sent by mistake, sorry. This isn't ready yet. I'll ...
4 years, 7 months ago (2016-04-29 18:13:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929203004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929203004/20001
4 years, 7 months ago (2016-04-29 18:19:21 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929203004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929203004/40001
4 years, 7 months ago (2016-04-29 18:29:50 UTC) #10
oshima
It's ready. Please review.
4 years, 7 months ago (2016-04-29 18:42:57 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929203004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929203004/60001
4 years, 7 months ago (2016-04-29 19:52:52 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 20:29:58 UTC) #18
oshima
tbring since this is small and basically same as https://codereview.chromium.org/1915363002
4 years, 7 months ago (2016-04-29 22:30:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929203004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929203004/60001
4 years, 7 months ago (2016-04-29 22:30:50 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-04-29 22:35:48 UTC) #24
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:43 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53682f2ee583aa28ba4e4721efbf28d8e2e59459
Cr-Commit-Position: refs/heads/master@{#390787}

Powered by Google App Engine
This is Rietveld 408576698