Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/protobuf/README.chromium

Issue 1929193002: Use offsetof in ZR_HELPER_ for Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: link github and crbug issues Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/protobuf/patches/0011-use-offsetof-for-clang.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/README.chromium
diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium
index 3453b849bf94369d40a42eed6515330974bc042f..0af6f79293d752e9d1bba1ce4224e80313803892 100644
--- a/third_party/protobuf/README.chromium
+++ b/third_party/protobuf/README.chromium
@@ -87,3 +87,12 @@ Description of the patches:
These patches uninline some functions, resulting in a significant reduction
(somewhere between 500 KB and 1 MB) of binary size.
+- 0011-use-offsetof-for-clang.patch
+
+ This patch replaces a few invalid reinterpret_casts with __builtin_offsetof,
+ if compiled with Clang. This is a temporary patch, it should be deletd, when
+ the official github repo is updates with this changes already submitted to
+ the internal Google repo.
+
+ See also: https://crbug.com/607751 and
+ https://github.com/google/protobuf/issues/1450
« no previous file with comments | « no previous file | third_party/protobuf/patches/0011-use-offsetof-for-clang.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698