third_party/protobuf/README.chromium - Issue 1929193002: Use offsetof in ZR_HELPER_ for Clang.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/README.chromium

Issue 1929193002: Use offsetof in ZR_HELPER_ for Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: link github and crbug issues Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Protocol Buffers	1 Name: Protocol Buffers

2 Short Name: protobuf	2 Short Name: protobuf

3 URL: https://github.com/google/protobuf	3 URL: https://github.com/google/protobuf

4 License: BSD	4 License: BSD

5 License File: LICENSE	5 License File: LICENSE

6 Version: 3.0.0-beta-2	6 Version: 3.0.0-beta-2

7 Revision: d5fb408ddc281ffcadeb08699e65bb694656d0bd	7 Revision: d5fb408ddc281ffcadeb08699e65bb694656d0bd

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Steps used to create the current version:	10 Steps used to create the current version:

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 3cc35adb6dca9057a790d253b9f5e2b9b000a106 and	80 3cc35adb6dca9057a790d253b9f5e2b9b000a106 and

81 58f07644eab25f68973ecab4bdc43fc318c26131.	81 58f07644eab25f68973ecab4bdc43fc318c26131.

82	82

83 - 0007-uninline_googleonce.patch	83 - 0007-uninline_googleonce.patch

84 - 0008-uninline_get_empty_string.patch	84 - 0008-uninline_get_empty_string.patch

85 - 0009-uninline-arenastring.patch	85 - 0009-uninline-arenastring.patch

86 - 0010-uninline-generated-code.patch	86 - 0010-uninline-generated-code.patch

87	87

88 These patches uninline some functions, resulting in a significant reduction	88 These patches uninline some functions, resulting in a significant reduction

89 (somewhere between 500 KB and 1 MB) of binary size.	89 (somewhere between 500 KB and 1 MB) of binary size.

	90 - 0011-use-offsetof-for-clang.patch

	91

	92 This patch replaces a few invalid reinterpret_casts with __builtin_offsetof,

	93 if compiled with Clang. This is a temporary patch, it should be deletd, when

	94 the official github repo is updates with this changes already submitted to

	95 the internal Google repo.

	96

	97 See also: https://crbug.com/607751 and

	98 https://github.com/google/protobuf/issues/1450

OLD	NEW

« no previous file with comments | « no previous file | third_party/protobuf/patches/0011-use-offsetof-for-clang.patch » ('j') | no next file with comments »