Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1929163003: Remove unnecessary exception for unknown_deps (Closed)

Created:
4 years, 7 months ago by bshe
Modified:
4 years, 7 months ago
Reviewers:
brettw, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary exception for unknown_deps The removed exception is raised when I am testing link to a jar file which extract from a .aar file through an action. For example: action("extract_aar") { script = ".." ... outputs = ["$root_out_dir/test.jar",] } android_java_prebuilt("test_prebuilt") { jar_path = "$root_out_dir/test.jar" deps = [":extract_aar"] } It looks like the exception is unnecessary anymore so removing it. BUG=NONE Committed: https://crrev.com/01ec845c3abedb6e8b279386577e521e0e43e9b8 Cr-Commit-Position: refs/heads/master@{#391586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/android/gyp/write_build_config.py View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
bshe
Hi Brett. I came across this issue (see description for detail) when I try to ...
4 years, 7 months ago (2016-04-29 20:10:23 UTC) #2
agrieve
On 2016/04/29 20:10:23, bshe wrote: > Hi Brett. > > I came across this issue ...
4 years, 7 months ago (2016-04-30 00:36:52 UTC) #3
brettw
agrieve's review should be good enough, I don't have much background in this script.
4 years, 7 months ago (2016-05-02 16:40:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929163003/1
4 years, 7 months ago (2016-05-04 17:37:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:54:14 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:55:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01ec845c3abedb6e8b279386577e521e0e43e9b8
Cr-Commit-Position: refs/heads/master@{#391586}

Powered by Google App Engine
This is Rietveld 408576698