Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: test/client_test.dart

Issue 1929063002: pkg/vm_service_client: add getSourceReport to VMServiceReference (Closed) Base URL: https://github.com/dart-lang/vm_service_client.git@master
Patch Set: changelog oops Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/client_test.dart
diff --git a/test/client_test.dart b/test/client_test.dart
index f7e7cba0863f256d9b25b5d56da2d7acc01273de..ca7b2b18fc33053468f1e6ee0cdb90281ead4f51 100644
--- a/test/client_test.dart
+++ b/test/client_test.dart
@@ -21,7 +21,7 @@ void main() {
client = await runAndConnect();
var version = await client.getVersion();
expect(version.major, equals(3));
- expect(version.minor, new isInstanceOf<int>());
+ expect(version.minor, greaterThanOrEqualTo(4));
nweiz 2016/04/29 00:52:44 Why are you making this change at all?
kevmoo 2016/04/29 23:36:55 Bumped version of SDK – assuming that the version
nweiz 2016/05/04 23:05:51 This isn't really a good reason to change existing
kevmoo 2016/05/05 20:46:25 Done.
});
test("considers the VM service version valid", () async {

Powered by Google App Engine
This is Rietveld 408576698