Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 19290008: Added tracing information to the case when allocation folding cannot be performed. (Closed)

Created:
7 years, 5 months ago by Hannes Payer (out of office)
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Added tracing information to the case when allocation folding cannot be performed. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15686

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/hydrogen-instructions.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-16 08:41:14 UTC) #1
Michael Starzinger
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc#newcode3185 src/hydrogen-instructions.cc:3185: return; nit: This early return should fit into one ...
7 years, 5 months ago (2013-07-16 08:44:35 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc#newcode3185 src/hydrogen-instructions.cc:3185: return; On 2013/07/16 08:44:36, Michael Starzinger wrote: > nit: ...
7 years, 5 months ago (2013-07-16 08:51:52 UTC) #3
Michael Starzinger
LGTM.
7 years, 5 months ago (2013-07-16 08:53:59 UTC) #4
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-16 08:54:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r15686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698