Added tracing information to the case when allocation folding cannot be performed.

src/hydrogen-instructions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3163 matching lines @@
 
 
 HType HAllocate::CalculateInferredType() {
   return type_;
 }
 
 
 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
                                           HValue* dominator) {
   ASSERT(side_effect == kChangesNewSpacePromotion);
-  // Try to fold allocations together with their dominating allocations.
-  if (!FLAG_use_allocation_folding || !dominator->IsAllocate()) {
+  if (!FLAG_use_allocation_folding) {
     return;

[Michael Starzinger, 2013/07/16 08:44:36]

nit: This early return should fit into one line.

[Hannes Payer (out of office), 2013/07/16 08:51:52]

Done.

   }
   HAllocate* dominator_allocate_instr = HAllocate::cast(dominator);

[Michael Starzinger, 2013/07/16 08:44:36]

This cast will fail if "dominator" is not an HAllocate.

[Hannes Payer (out of office), 2013/07/16 08:51:52]

Yes, then I guess I have to duplicate the tracing output.

   HValue* dominator_size = dominator_allocate_instr->size();
   HValue* current_size = size();
+  // Try to fold allocations together with their dominating allocations.
   // We can just fold allocations that are guaranteed in new space.
   // TODO(hpayer): Support double aligned allocations.
   // TODO(hpayer): Add support for non-constant allocation in dominator.
   if (!GuaranteedInNewSpace() || MustAllocateDoubleAligned() ||
       !current_size->IsInteger32Constant() ||
+      !dominator->IsAllocate() ||
       !dominator_allocate_instr->GuaranteedInNewSpace() ||
       dominator_allocate_instr->MustAllocateDoubleAligned() ||
       !dominator_size->IsInteger32Constant()) {
+    if (FLAG_trace_allocation_folding) {
+      PrintF("#%d (%s) cannot fold into #%d (%s)\n",
+          id(), Mnemonic(), dominator->id(), dominator->Mnemonic());
+    }
     return;
   }
 
   // First update the size of the dominator allocate instruction.
   int32_t dominator_size_constant =
       HConstant::cast(dominator_size)->GetInteger32Constant();
   int32_t current_size_constant =
       HConstant::cast(current_size)->GetInteger32Constant();
   HBasicBlock* block = dominator->block();
   Zone* zone = block->zone();
@@ skipping 760 matching lines @@
     case kBackingStore:
       if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
       stream->Add("[backing-store]");
       break;
   }
 
   stream->Add("@%d", offset());
 }
 
 } }  // namespace v8::internal