Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1928983002: Add next_version_mini_installer target. (Closed)

Created:
4 years, 7 months ago by fdoray
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add next_version_mini_installer target. This target generates next_version_mini_installer.exe, which has a higher version number than mini_installer.exe. This new installer will be used to test various update scenarios (using test_installer.py). next_version_mini_installer needs to be added to the list of dependencies of MiniInstallerTest before tests start using it. (build/scripts/slave/recipe_modules/chromium_tests/steps.py) This CL is based on https://codereview.chromium.org/1902233003 which was reverted because it broke Win Builder. To avoid this problem, this CL adds next_version_mini_installer.exe to the list of files excluded from the checkbins step. BUG=605177 Committed: https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895 Cr-Commit-Position: refs/heads/master@{#390503}

Patch Set 1 : Same as https://codereview.chromium.org/1902233003/ #

Patch Set 2 : exclude next_version_mini_installer.exe from checkbins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -3 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M build/all.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +39 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/installer/mini_installer/generate_next_version_mini_installer.py View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/installer/test/alternate_version_generator_main.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/checkbins/checkbins.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fdoray
grt@chromium.org: Please review changes in chrome/installer/ dpranke@chromium.org: Please review changes in BUILD.gn, build/*, tools/*. This ...
4 years, 7 months ago (2016-04-28 14:15:36 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-28 19:36:16 UTC) #3
grt (UTC plus 2)
lgtm
4 years, 7 months ago (2016-04-28 19:56:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928983002/20001
4 years, 7 months ago (2016-04-28 20:02:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 22:07:45 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb048bff9ec1ecdb632386878c33168a77b75895
Cr-Commit-Position: refs/heads/master@{#390503}

Powered by Google App Engine
This is Rietveld 408576698