Add next_version_mini_installer target.

Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
Committed: https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28
Cr-Commit-Position: refs/heads/master@{#390158}

[fdoray, 2016-04-20 17:54:05]

Description was changed from

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. The new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
==========

to

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
==========

[fdoray, 2016-04-20 19:49:20]

fdoray@chromium.org changed reviewers:
+ grt@chromium.org

[fdoray, 2016-04-20 19:49:20]

Can you review this CL? Thanks.

[grt (UTC plus 2), 2016-04-20 20:00:42]

cool. lgtm. i hope it works. :-)

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/BUILD.gn (right):

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/BUILD.gn:209: script =
"generate_next_version_mini_installer.py"
is there no way to run the command without wrapping it in python?

[fdoray, 2016-04-20 20:42:44]

fdoray@chromium.org changed reviewers:
+ dpranke@chromium.org

[fdoray, 2016-04-20 20:42:45]

dpranke@: Can you review BUILD.gn, build/all.gyp and build/gn_migration.gypi?
Thanks.

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/BUILD.gn (right):

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/BUILD.gn:209: script =
"generate_next_version_mini_installer.py"
On 2016/04/20 20:00:42, grt wrote:
> is there no way to run the command without wrapping it in python?

GN prepends the Python path to the provided script when it builds the command
for an "action" target [1]. I tried to put alternate_version_generator.exe here
but it didn't work.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/ninja_act...

[Dirk Pranke, 2016-04-20 21:33:33]

lgtm

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/BUILD.gn (right):

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/BUILD.gn:209: script =
"generate_next_version_mini_installer.py"
On 2016/04/20 20:42:44, fdoray wrote:
> On 2016/04/20 20:00:42, grt wrote:
> > is there no way to run the command without wrapping it in python?
> 
> GN prepends the Python path to the provided script when it builds the command
> for an "action" target [1]. I tried to put alternate_version_generator.exe
here
> but it didn't work.
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/ninja_act...

Right, GN only supports calling out to python scripts.

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/BUILD.gn:211: next_version_mini_installer_exe =
"next_version_mini_installer.exe"
Nit: this could be "$target_name.exe" instead, or you could just use
"$target_name.exe" below.

[fdoray, 2016-04-21 13:14:13]

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/BUILD.gn (right):

https://codereview.chromium.org/1902233003/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/BUILD.gn:211: next_version_mini_installer_exe =
"next_version_mini_installer.exe"
On 2016/04/20 21:33:33, Dirk Pranke wrote:
> Nit: this could be "$target_name.exe" instead, or you could just use
> "$target_name.exe" below.

Done.

[fdoray, 2016-04-21 13:14:16]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-04-21 13:14:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1902233003/#ps20001
(title: "use $target_name.exe")

[commit-bot: I haz the power, 2016-04-21 13:14:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902233003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902233003/20001

[commit-bot: I haz the power, 2016-04-21 13:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 13:21:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2016-04-21 13:26:47]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-04-21 13:26:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1902233003/#ps40001
(title: "remove shebang from generate_next_version_mini_installer.py")

[commit-bot: I haz the power, 2016-04-21 13:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902233003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902233003/40001

[commit-bot: I haz the power, 2016-04-21 15:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 15:17:52]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[fdoray, 2016-04-25 13:57:26]

grt@:

alternate_version_generator.exe fails with this error with a component build on
my machine and on bots:
[0421/075359:ERROR:resource_updater.cc(51)] UpdateResource failed for resource
"CHROME.7Z" of size 1203628116 bytes: Not enough storage is available to process
this command. (0x8)

I disabled the next_version_mini_installer target for component builds to avoid
this failure. Do I still have your lgtm?

[zmin, 2016-04-26 19:54:57]

zmin@chromium.org changed reviewers:
+ zmin@chromium.org

[zmin, 2016-04-26 19:54:58]

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
File chrome/installer/mini_installer/generate_next_version_mini_installer.py
(right):

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
chrome/installer/mini_installer/generate_next_version_mini_installer.py:7:
import optparse
Because optparse is deprecated in
2.7(https://docs.python.org/2/library/optparse.html). Shall we keep using this?

[grt (UTC plus 2), 2016-04-26 20:41:11]

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
File chrome/installer/mini_installer/generate_next_version_mini_installer.py
(right):

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
chrome/installer/mini_installer/generate_next_version_mini_installer.py:7:
import optparse
On 2016/04/26 19:54:58, zmin wrote:
> Because optparse is deprecated in
> 2.7(https://docs.python.org/2/library/optparse.html). Shall we keep using
this?

https://crrev.com/220396! :-)

argparse is indeed the way to go these days. nice catch!

[fdoray, 2016-04-27 15:35:39]

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
File chrome/installer/mini_installer/generate_next_version_mini_installer.py
(right):

https://codereview.chromium.org/1902233003/diff/80001/chrome/installer/mini_i...
chrome/installer/mini_installer/generate_next_version_mini_installer.py:7:
import optparse
On 2016/04/26 20:41:10, grt wrote:
> On 2016/04/26 19:54:58, zmin wrote:
> > Because optparse is deprecated in
> > 2.7(https://docs.python.org/2/library/optparse.html). Shall we keep using
> this?
> 
> https://crrev.com/220396! :-)
> 
> argparse is indeed the way to go these days. nice catch!

Done.

[zmin, 2016-04-27 15:42:32]

lgtm

[zmin, 2016-04-27 15:42:35]

lgtm

[fdoray, 2016-04-27 17:33:45]

grt@: Do I still have your lgtm?

[grt (UTC plus 2), 2016-04-27 18:35:29]

lgtm

[eclipse0072015, 2016-04-27 18:36:26]

eclipse0072015@gmail.com changed reviewers:
+ eclipse0072015@gmail.com

[fdoray, 2016-04-27 18:58:25]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-04-27 18:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1902233003/#ps100001
(title: "disable for x86/Debug/component builds")

[commit-bot: I haz the power, 2016-04-27 18:58:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902233003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902233003/100001

[commit-bot: I haz the power, 2016-04-27 20:00:36]

Description was changed from

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
==========

to

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
==========

[commit-bot: I haz the power, 2016-04-27 20:00:37]

Committed patchset #6 (id:100001)

[Justin Donnelly, 2016-04-27 21:22:07]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1926893002/ by jdonnelly@chromium.org.

The reason for reverting is: Broke the Win builder:
https://build.chromium.org/p/chromium/builders/Win/builds/42817

Failed step checkbins:

Checking
C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for
/DYNAMICBASE... FAIL
Checking
C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for
/NXCOMPAT... PASS
Checking
C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for
/SAFESEH... PASS.

[commit-bot: I haz the power, 2016-04-30 17:12:17]

Patchset 6 (id:??) landed as
https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28
Cr-Commit-Position: refs/heads/master@{#390158}

[commit-bot: I haz the power, 2016-04-30 17:51:25]

Description was changed from

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177
==========

to

==========
Add next_version_mini_installer target.

This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).

next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)

BUG=605177

Committed: https://crrev.com/f60b933129fc5da66040af05cd22701dfcea8a28
Cr-Commit-Position: refs/heads/master@{#390158}
==========