[heap] Bail out to regular evacuation if new->old fails to allocate a page

[heap] Bail out to regular evacuation if new->old fails to allocate a page

BUG=chromium:607226, chromium:581412
LOG=N

Committed: https://crrev.com/4c880dec6291041d53302d595db9bc948ebf6f52
Cr-Commit-Position: refs/heads/master@{#35844}

[Michael Lippautz, 2016-04-28 06:34:59]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 06:35:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928883002/1

[Michael Lippautz, 2016-04-28 06:40:57]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-04-28 06:40:58]

ptal

[Hannes Payer (out of office), 2016-04-28 06:55:48]

lgtm

https://codereview.chromium.org/1928883002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1928883002/diff/1/src/heap/spaces.cc#newcode1832
src/heap/spaces.cc:1832: if (new_page == nullptr) return false;
Maybe leave a TODO here that we do not have to get a new page when we are about
to uncommit and shrink the semi space anyway later.

[Michael Lippautz, 2016-04-28 07:00:58]

https://codereview.chromium.org/1928883002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1928883002/diff/1/src/heap/spaces.cc#newcode1832
src/heap/spaces.cc:1832: if (new_page == nullptr) return false;
On 2016/04/28 06:55:48, Hannes Payer wrote:
> Maybe leave a TODO here that we do not have to get a new page when we are
about
> to uncommit and shrink the semi space anyway later.

Done.

[Michael Lippautz, 2016-04-28 07:01:08]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 07:01:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928883002/20001

[commit-bot: I haz the power, 2016-04-28 07:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 07:54:15]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-04-28 07:58:01]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-04-28 07:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1928883002/#ps20001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-04-28 07:58:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928883002/20001

[commit-bot: I haz the power, 2016-04-28 08:01:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-01 22:01:49]

Description was changed from

==========
[heap] Bail out to regular evacuation if new->old fails to allocate a page

BUG=chromium:607226, chromium:581412
LOG=N
==========

to

==========
[heap] Bail out to regular evacuation if new->old fails to allocate a page

BUG=chromium:607226, chromium:581412
LOG=N

Committed: https://crrev.com/4c880dec6291041d53302d595db9bc948ebf6f52
Cr-Commit-Position: refs/heads/master@{#35844}
==========

[commit-bot: I haz the power, 2016-05-01 22:01:50]

Patchset 2 (id:??) landed as
https://crrev.com/4c880dec6291041d53302d595db9bc948ebf6f52
Cr-Commit-Position: refs/heads/master@{#35844}