Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/heap/spaces.h

Issue 1928883002: [heap] Bail out to regular evacuation if new->old fails to allocate a page (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index c468ca4d87ff8964e4a8c9fbaf8d0854571b335c..7ddd905877ab388a723d183b81506e126e2d6be9 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -2381,7 +2381,7 @@ class SemiSpace : public Space {
// Resets the space to using the first page.
void Reset();
- void ReplaceWithEmptyPage(Page* page);
+ bool ReplaceWithEmptyPage(Page* page);
// Age mark accessors.
Address age_mark() { return age_mark_; }
@@ -2603,10 +2603,10 @@ class NewSpace : public Space {
inline size_t AllocatedSinceLastGC();
- void ReplaceWithEmptyPage(Page* page) {
+ bool ReplaceWithEmptyPage(Page* page) {
// This method is called after flipping the semispace.
DCHECK(page->InFromSpace());
- from_space_.ReplaceWithEmptyPage(page);
+ return from_space_.ReplaceWithEmptyPage(page);
}
// Return the maximum capacity of a semispace.
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698