Issue 192883005: Fix issue with getOwnPropertySymbols and hidden properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192883005: Fix issue with getOwnPropertySymbols and hidden properties (Closed)

Created:
6 years, 9 months ago by arv (Not doing code reviews)

Modified:
6 years, 9 months ago

Reviewers:
rossberg, Toon Verwaest

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix issue with getOwnPropertySymbols and hidden properties When getting the symbols of an object we need to ignore the hidden properties of the prototype object since the hidden properties are represented by a single string key and we will not include that hidden string in the found names. BUG=350864 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19813

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -15 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-350864.js	View		1 chunk	+8 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

6 years, 9 months ago (2014-03-11 16:46:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19813 (presubmit successful).

Expand Messages | Collapse Messages