Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: src/runtime.cc

Issue 192883005: Fix issue with getOwnPropertySymbols and hidden properties (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-350864.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 394deceaa8e82b3ea4b08ff0c2f159fbbf330325..c50b3c459bbd7443fb3cf7aa5e53c9dabd4502e3 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -5811,7 +5811,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GetLocalPropertyNames) {
}
}
next_copy_index += local_property_count[i];
- if (jsproto->HasHiddenProperties()) {
+
+ // Hidden properties only show up if the filter does not skip strings.
+ if ((filter & STRING) == 0 && jsproto->HasHiddenProperties()) {
hidden_strings++;
}
if (i < length - 1) {
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-350864.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698