Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1928783004: Extend chromium_tests trigger to work across masters. (Closed)

Created:
4 years, 7 months ago by dtu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Extend chromium_tests trigger to work across masters. A bot can specify "parent_mastername" to choose which master to trigger from. Also, merge all the trigger steps to one. For perf bots, it was generating 20+ steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300383 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300535

Patch Set 1 #

Patch Set 2 : Expectations #

Total comments: 2

Patch Set 3 : parent_master --> parent_mastername #

Patch Set 4 : Exclude bucket when not needed. Exclude trigger step when not needed. #

Patch Set 5 : Include all the master data in the bot db. Change chromium.perf.fyi builder for coverage. #

Total comments: 2

Patch Set 6 : REbase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -1448 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 2 3 4 5 1 chunk +7 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py View 1 2 3 4 3 chunks +37 lines, -26 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json View 1 2 3 4 5 9 chunks +9 lines, -81 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 2 3 4 5 5 chunks +5 lines, -41 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder__dbg_.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json View 1 2 3 4 5 5 chunks +5 lines, -41 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json View 1 2 3 4 5 7 chunks +7 lines, -61 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json View 1 2 3 4 5 4 chunks +4 lines, -31 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json View 1 2 3 4 5 7 chunks +7 lines, -61 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json View 1 2 3 4 5 4 chunks +4 lines, -31 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 2 3 4 5 3 chunks +3 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json View 1 2 3 4 5 18 chunks +18 lines, -171 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_arm64_Builder.json View 1 2 3 4 5 3 chunks +3 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json View 1 2 3 4 5 5 chunks +5 lines, -41 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json View 1 2 3 4 5 20 chunks +20 lines, -191 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json View 1 2 3 4 5 7 chunks +7 lines, -61 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json View 1 2 3 4 5 35 chunks +55 lines, -341 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_7_Intel_GPU_Perf__Xeon_.json View 1 2 3 4 5 5 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_x64_FYI_Builder.json View 1 2 3 4 5 1 chunk +1 line, -29 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json View 1 2 3 4 5 3 chunks +3 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder__dbg_.json View 1 2 3 4 5 4 chunks +4 lines, -31 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json View 1 2 3 4 5 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
dtu
4 years, 7 months ago (2016-04-28 14:32:09 UTC) #3
Paweł Hajdan Jr.
LGTM w/comment https://codereview.chromium.org/1928783004/diff/20001/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1928783004/diff/20001/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode194 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:194: bot_config.get('parent_master', mastername) == parent_mastername) Let's be consistent ...
4 years, 7 months ago (2016-04-29 18:49:26 UTC) #6
dtu
https://codereview.chromium.org/1928783004/diff/20001/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1928783004/diff/20001/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode194 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:194: bot_config.get('parent_master', mastername) == parent_mastername) On 2016/04/29 at 18:49:26, Paweł ...
4 years, 7 months ago (2016-04-30 02:51:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928783004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928783004/40001
4 years, 7 months ago (2016-04-30 02:51:16 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300383
4 years, 7 months ago (2016-04-30 02:56:33 UTC) #13
Dirk Pranke
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1932213004/ by dpranke@chromium.org. ...
4 years, 7 months ago (2016-04-30 18:10:18 UTC) #14
dtu
Fixed! PTAL. Let me know if you prefer a separate CL or CLs for the ...
4 years, 7 months ago (2016-05-04 00:40:36 UTC) #16
nodir
no need to specify bucket if you are intend to trigger a build on the ...
4 years, 7 months ago (2016-05-04 01:41:47 UTC) #18
nodir
err nvm
4 years, 7 months ago (2016-05-04 01:50:34 UTC) #19
dtu
Friendly pong
4 years, 7 months ago (2016-05-05 23:34:30 UTC) #20
nodir
the part the caused the outage last time lgtm because most of trigger specs do ...
4 years, 7 months ago (2016-05-06 00:58:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928783004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928783004/80001
4 years, 7 months ago (2016-05-10 22:05:03 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: Build Try Recipe Test Trusty64 on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20Test%20Trusty64/builds/1541)
4 years, 7 months ago (2016-05-10 22:06:39 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928783004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928783004/100001
4 years, 7 months ago (2016-05-10 22:13:16 UTC) #29
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 22:18:35 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300535

Powered by Google App Engine
This is Rietveld 408576698