scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py - Issue 1928783004: Extend chromium_tests trigger to work across masters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

Issue 1928783004: Extend chromium_tests trigger to work across masters. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: REbase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

index e13e6726fcaa8ff68a22dbdb466e46051022e3cb..37c5e57ed811a441c66e9c63c7a974febad1f078 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

@@ -8,7 +8,8 @@ from . import steps

RESULTS_URL = 'https://chromeperf.appspot.com'

-def _AddBotSpec(name, platform, parent_builder, perf_id, target_bits):

+def _AddBotSpec(name, platform, parent_builder, perf_id, target_bits,

+ parent_master=None):

SPEC['builders'][name] = {

'disable_tests': True,

'bot_type': 'tester',

@@ -29,6 +30,8 @@ def _AddBotSpec(name, platform, parent_builder, perf_id, target_bits):

shard_index=0, num_host_shards=1),

}

+ if parent_master:

+ SPEC['builders'][name]['parent_mastername'] = parent_master

SPEC = {

@@ -81,9 +84,10 @@ SPEC = {

_AddBotSpec(

name='Win 7 Intel GPU Perf (Xeon)',

platform='win',

- parent_builder='Win x64 FYI Builder',

+ parent_builder='Win x64 Builder',

perf_id='chromium-rel-win7-gpu-intel',

- target_bits=64)

+ target_bits=64,

+ parent_master='chromium.perf')

_AddBotSpec(

name='Win Clang Perf',