Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1928783003: Revert of [Mac][Material Design] Rework how location bar shadow is drawn. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac][Material Design] Rework how location bar shadow is drawn. (patchset #4 id:60001 of https://codereview.chromium.org/1905163002/ ) Reason for revert: Change can cause a crash when installing a theme. Original issue's description: > [Mac][Material Design] Rework how location bar shadow is drawn. > > The location bar in Material Design has a very faint line of shadow > beneath it in Incognito mode. I originally accomplished this by drawing > it within the bounds of the location bar but by borrowing a pixel row I > changed the height of the interior of the location bar, causing items > within the bar to no longer be vertically centered. This change moves > the shadow into a separate view. > > R=tapted@chromium.org > BUG=594847 TBR=tapted@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594847 Committed: https://crrev.com/ed1eee6bf1253dcce9eb0d8a0ef0bee86c70f3ac Cr-Commit-Position: refs/heads/master@{#390210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -108 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 2 chunks +11 lines, -95 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shrike
Created Revert of [Mac][Material Design] Rework how location bar shadow is drawn.
4 years, 7 months ago (2016-04-27 22:11:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928783003/1
4 years, 7 months ago (2016-04-27 22:11:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 22:12:41 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed1eee6bf1253dcce9eb0d8a0ef0bee86c70f3ac
Cr-Commit-Position: refs/heads/master@{#390210}

Powered by Google App Engine
This is Rietveld 408576698