Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

Issue 1928783003: Revert of [Mac][Material Design] Rework how location bar shadow is drawn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
index b75fcf4bc1216b7c801c41cef3b125a82e507aec..ca33657b14d0dff8605484b03c4dbdfc727d9b95 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
@@ -314,6 +314,10 @@
// Compute the border's bezier path.
NSRect pathRect = NSInsetRect(frame, insetSize, insetSize);
+ // In dark mode, make room for a shadow beneath the bottom edge.
+ if (inDarkMode && isModeMaterial) {
+ pathRect.size.height -= singlePixelLineWidth_;
+ }
NSBezierPath* path =
[NSBezierPath bezierPathWithRoundedRect:pathRect
xRadius:kCornerRadius
@@ -362,7 +366,7 @@
}
// Draw a highlight beneath the top edge, and a shadow beneath the bottom
- // edge when on a Retina screen.
+ // edge.
{
gfx::ScopedNSGraphicsContextSaveGState saveState;
[NSBezierPath setDefaultLineWidth:singlePixelLineWidth_];
@@ -376,12 +380,10 @@
[NSBezierPath strokeLineFromPoint:origin
toPoint:destination];
- if (singlePixelLineWidth_ < 1) {
- origin.y = destination.y = NSMaxY(pathRect) + singlePixelLineWidth_;
- [[AutocompleteTextField shadowColor] set];
- [NSBezierPath strokeLineFromPoint:origin
- toPoint:destination];
- }
+ origin.y = destination.y = NSMaxY(pathRect) + singlePixelLineWidth_;
+ [[NSColor colorWithCalibratedWhite:69 / 255. alpha:1] set];
+ [NSBezierPath strokeLineFromPoint:origin
+ toPoint:destination];
}
}
} else {
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698