[wasm] Fix turbolizer output

[wasm] Fix turbolizer output

The header / start of the json file was missing before.

R=ahaas@chromium.org, titzer@chromium.org

Committed: https://crrev.com/295e7a08a28332962e8de39bdfdbbe2fafbafdb0
Cr-Commit-Position: refs/heads/master@{#35901}

[titzer, 2016-04-27 12:00:10]

lgtm

[Clemens Hammacher, 2016-04-27 12:07:50]

clemensh@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Clemens Hammacher, 2016-04-27 12:07:58]

+bmeurer

waiting for this bigger CL to land, will rebase then:
https://codereview.chromium.org/1179393008/

[Clemens Hammacher, 2016-04-27 14:37:24]

On 2016/04/27 at 12:07:58, Clemens Hammacher wrote:
> +bmeurer
> 
> waiting for this bigger CL to land, will rebase then:
https://codereview.chromium.org/1179393008/

Of course the other CL changed everything, so the new patch is a bit bigger than
before :-/

PTAL

[ahaas, 2016-04-27 14:45:22]

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:1468: if (FLAG_trace_turbo) {
Why do you write the header only if there is no schedule?

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.h...
src/compiler/pipeline.h:86: void RunPrintAndVerify(const char* phase, bool
untyped = false);
Could you add a TODO here that this function should not be public? If
ScheduleAndSelectInstructions should not be public, then also this one should
not be public.

[Clemens Hammacher, 2016-04-27 14:58:55]

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:1468: if (FLAG_trace_turbo) {
On 2016/04/27 at 14:45:22, ahaas wrote:
> Why do you write the header only if there is no schedule?

Because also the RunPrintAndVerity is only executed if there is no schedule. I
assumed there is some rationale behind that.
But since I do not find it either, I will remove the whole check for
schedule==nullptr if no one objects.

For wasm, it does not matter anyway, since we never pass a schedule. Since there
are no tests for such cases, let's hope that it is correct in the general case.

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/1928503002/diff/10001/src/compiler/pipeline.h...
src/compiler/pipeline.h:86: void RunPrintAndVerify(const char* phase, bool
untyped = false);
On 2016/04/27 at 14:45:22, ahaas wrote:
> Could you add a TODO here that this function should not be public? If
ScheduleAndSelectInstructions should not be public, then also this one should
not be public.

Done (not uploaded yet).

[titzer, 2016-04-28 08:39:58]

https://codereview.chromium.org/1928503002/diff/30001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/1928503002/diff/30001/src/compiler/pipeline.h...
src/compiler/pipeline.h:87: void RunPrintAndVerify(const char* phase, bool
untyped = false);
I think it'd be better to make PipelineWasmCompilationJob a friend class with a
forward declaration above.

[Clemens Hammacher, 2016-04-28 15:30:09]

https://codereview.chromium.org/1928503002/diff/30001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/1928503002/diff/30001/src/compiler/pipeline.h...
src/compiler/pipeline.h:87: void RunPrintAndVerify(const char* phase, bool
untyped = false);
On 2016/04/28 at 08:39:58, titzer wrote:
> I think it'd be better to make PipelineWasmCompilationJob a friend class with
a forward declaration above.

Yes, I think this is nicer, even though the PipelineWasmCompilationJob had to be
moved out of the anonymous namespace in pipeline.cc in order to be
forward-referencable.

[Clemens Hammacher, 2016-04-29 11:37:20]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-29 11:37:21]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1928503002/#ps50001
(title: "address titzer's comments")

[commit-bot: I haz the power, 2016-04-29 11:37:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928503002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928503002/50001

[commit-bot: I haz the power, 2016-04-29 11:41:33]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-05-01 22:03:38]

Description was changed from

==========
[wasm] Fix turbolizer output

The header / start of the json file was missing before.

R=ahaas@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] Fix turbolizer output

The header / start of the json file was missing before.

R=ahaas@chromium.org, titzer@chromium.org

Committed: https://crrev.com/295e7a08a28332962e8de39bdfdbbe2fafbafdb0
Cr-Commit-Position: refs/heads/master@{#35901}
==========

[commit-bot: I haz the power, 2016-05-01 22:03:39]

Patchset 4 (id:??) landed as
https://crrev.com/295e7a08a28332962e8de39bdfdbbe2fafbafdb0
Cr-Commit-Position: refs/heads/master@{#35901}