Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/compiler/pipeline.h

Issue 1928503002: [wasm] Fix turbolizer output (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address titzer's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.h
diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h
index 464014518f4100b8c40ff25d02b2ff84483388be..da4a2150296c49c318951aac25ade7dcaeeeec3d 100644
--- a/src/compiler/pipeline.h
+++ b/src/compiler/pipeline.h
@@ -80,10 +80,11 @@ class Pipeline {
CompilationInfo* info, Graph* graph, CallDescriptor* descriptor,
SourcePositionTable* source_positions);
- // TODO(mstarzinger, bmeurer): This shouldn't be public!
- bool ScheduleAndSelectInstructions(Linkage* linkage);
-
private:
+ // The wasm compilation job calls ScheduleAndSelectInstructions and
+ // RunPrintAndVerify, so we make it a member class.
+ friend class PipelineWasmCompilationJob;
+
// Helpers for executing pipeline phases.
template <typename Phase>
void Run();
@@ -94,6 +95,7 @@ class Pipeline {
void BeginPhaseKind(const char* phase_kind);
void EndPhaseKind();
+ bool ScheduleAndSelectInstructions(Linkage* linkage);
void RunPrintAndVerify(const char* phase, bool untyped = false);
Handle<Code> ScheduleAndGenerateCode(CallDescriptor* call_descriptor);
void AllocateRegisters(const RegisterConfiguration* config,
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698