third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp - Issue 1928163002: Add a name attribute for each AudioParam

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 1928163002: Add a name attribute for each AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use enum instead of string Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioParam.h ('K') | « third_party/WebKit/Source/modules/webaudio/DelayNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/GainNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

index ce43aebbc69391b075346c8bcb5f6be9041e27e8..943422f2db5af1977d70c6c163922dd6e8288a76 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

@@ -127,11 +127,11 @@ double DynamicsCompressorHandler::latencyTime() const

DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, float sampleRate)

: AudioNode(context)

- , m_threshold(AudioParam::create(context, -24))

- , m_knee(AudioParam::create(context, 30))

- , m_ratio(AudioParam::create(context, 12))

- , m_attack(AudioParam::create(context, 0.003))

- , m_release(AudioParam::create(context, 0.250))

+ , m_threshold(AudioParam::create(context, AudioParamHandler::DynamicsCompressorThreshold, -24))

+ , m_knee(AudioParam::create(context, AudioParamHandler::DynamicsCompressorKnee, 30))

+ , m_ratio(AudioParam::create(context, AudioParamHandler::DynamicsCompressorRatio, 12))

+ , m_attack(AudioParam::create(context, AudioParamHandler::DynamicsCompressorAttack, 0.003))

+ , m_release(AudioParam::create(context, AudioParamHandler::DynamicsCompressorRelease, 0.250))

{

setHandler(DynamicsCompressorHandler::create(

*this,