third_party/WebKit/Source/modules/webaudio/GainNode.cpp - Issue 1928163002: Add a name attribute for each AudioParam

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/GainNode.cpp

Issue 1928163002: Add a name attribute for each AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use enum instead of string Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/GainNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

index 581becbcc31791bc67c4fb32593f2ccab243c4c2..46d26a5e5bc95c9b4e0ee9ac97fa006012f05e41 100644

--- a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

@@ -116,7 +116,7 @@ void GainHandler::checkNumberOfChannelsForInput(AudioNodeInput* input)

GainNode::GainNode(AbstractAudioContext& context, float sampleRate)

: AudioNode(context)

- , m_gain(AudioParam::create(context, 1.0))

+ , m_gain(AudioParam::create(context, AudioParamHandler::GainGain, 1.0))

{

setHandler(GainHandler::create(*this, sampleRate, m_gain->handler()));

}