Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1928043002: Add drawImage() originClean() getSecurityOrigin() to OffscreenCanvas (Closed)

Created:
4 years, 7 months ago by xlai (Olivia)
Modified:
4 years, 7 months ago
Reviewers:
haraken, Justin Novosad
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, Rik, blink-reviews-bindings_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add drawImage() originClean() getSecurityOrigin() to OffscreenCanvas This patch adds m_originClean flag to OffscreenCanvas and ensures that OCRC2D also use the value of this flag instead of keeping its own redundant copy. It propagates the value of originClean in transferToImageBitmap(). This patch also expose drawImage() API functions in ORCRC2D in workers. BUG=563870, 563856 Committed: https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e Cr-Commit-Position: refs/heads/master@{#391002}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase master and Edited based on haraken's comment #

Total comments: 1

Patch Set 3 : Put back CallWith=ScriptState #

Total comments: 3

Patch Set 4 : Expose DrawImage + added the content security test #

Total comments: 2

Patch Set 5 : one more layout tests #

Patch Set 6 : Add crbug to TODO comment + rebase with master #

Patch Set 7 : drawImage API added to interface listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -56 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-in-worker.html View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-in-worker-expected.html View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-transferToImageBitmap.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-transferToImageBitmap-expected.txt View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 2 3 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 3 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.idl View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 33 (16 generated)
xlai (Olivia)
4 years, 7 months ago (2016-04-28 17:14:58 UTC) #5
haraken
https://codereview.chromium.org/1928043002/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp (right): https://codereview.chromium.org/1928043002/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp#newcode2283 third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:2283: ExecutionContext* executionContext = ScriptState::current(v8::Isolate::GetCurrent())->getExecutionContext(); Use m_reader.scriptState() instead. (Please don't ...
4 years, 7 months ago (2016-04-28 17:40:41 UTC) #7
xlai (Olivia)
https://codereview.chromium.org/1928043002/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp (right): https://codereview.chromium.org/1928043002/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp#newcode2283 third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:2283: ExecutionContext* executionContext = ScriptState::current(v8::Isolate::GetCurrent())->getExecutionContext(); On 2016/04/28 17:40:41, haraken wrote: ...
4 years, 7 months ago (2016-04-28 18:38:16 UTC) #8
Justin Novosad
https://codereview.chromium.org/1928043002/diff/20001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right): https://codereview.chromium.org/1928043002/diff/20001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp#newcode16 third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:16: : m_executionContext(executionContext) If haraken thinks this is safe, I ...
4 years, 7 months ago (2016-04-28 19:38:12 UTC) #9
haraken
On 2016/04/28 19:38:12, Justin Novosad wrote: > https://codereview.chromium.org/1928043002/diff/20001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp > File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right): > > https://codereview.chromium.org/1928043002/diff/20001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp#newcode16 ...
4 years, 7 months ago (2016-04-28 19:43:00 UTC) #10
xlai (Olivia)
Cleaning up the m_executionContext in OffscreenCanvas. Instead, put back all the "CallWith=ScriptState".
4 years, 7 months ago (2016-04-28 20:21:30 UTC) #13
Justin Novosad
https://codereview.chromium.org/1928043002/diff/40001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right): https://codereview.chromium.org/1928043002/diff/40001/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp#newcode113 third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:113: SecurityOrigin* OffscreenCanvas::getSecurityOrigin(ScriptState* scriptState) const This method is not needed ...
4 years, 7 months ago (2016-04-29 04:08:55 UTC) #14
xlai (Olivia)
Expose drawImage() in OCRC2D in worker only at this moment. I will write need more ...
4 years, 7 months ago (2016-04-29 18:57:01 UTC) #16
Justin Novosad
https://codereview.chromium.org/1928043002/diff/60001/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl File third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl (right): https://codereview.chromium.org/1928043002/diff/60001/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl#newcode34 third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl:34: // TODO: Expose these API to Window with more ...
4 years, 7 months ago (2016-04-29 19:29:04 UTC) #18
xlai (Olivia)
4 years, 7 months ago (2016-04-29 19:53:11 UTC) #19
Justin Novosad
On 2016/04/29 19:53:11, xlai (Olivia) wrote: lgtm
4 years, 7 months ago (2016-04-29 19:56:29 UTC) #20
haraken
LGTM
4 years, 7 months ago (2016-04-29 20:00:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928043002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928043002/100001
4 years, 7 months ago (2016-05-02 15:51:51 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/214782)
4 years, 7 months ago (2016-05-02 16:56:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928043002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928043002/120001
4 years, 7 months ago (2016-05-02 17:13:07 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-02 18:33:14 UTC) #31
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:34:34 UTC) #33
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/23378f8baae5d52320bb4652984b3f045f0bd95e
Cr-Commit-Position: refs/heads/master@{#391002}

Powered by Google App Engine
This is Rietveld 408576698