Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1928013003: Fix a crash in LocalDiscoveryUIHandler. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash in LocalDiscoveryUIHandler. GetCloudPrintProxyService() can return NULL in guest mode. BUG=607426 Committed: https://crrev.com/53ded7edaf64916e44fe6f16f025b9f86a178df1 Cr-Commit-Position: refs/heads/master@{#390697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
I didn't know guest mode existed on the desktop. Thought it was ChromeOS only.
4 years, 7 months ago (2016-04-29 00:58:34 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 7 months ago (2016-04-29 17:00:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928013003/1
4 years, 7 months ago (2016-04-29 18:03:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 18:07:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/53ded7edaf64916e44fe6f16f025b9f86a178df1
Cr-Commit-Position: refs/heads/master@{#390697}

Powered by Google App Engine
This is Rietveld 408576698