chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc - Issue 1928013003: Fix a crash in LocalDiscoveryUIHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 1928013003: Fix a crash in LocalDiscoveryUIHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

index 50af64807bcf4bf624716586fbd79ca59f085058..39378e32c35c788d932c4e1cecfdee0931069271 100644

--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

@@ -604,7 +604,9 @@ void LocalDiscoveryUIHandler::SetupCloudPrintConnectorSection() {

}

void LocalDiscoveryUIHandler::RefreshCloudPrintStatusFromService() {

- GetCloudPrintProxyService()->RefreshStatusFromService();

+ auto* service = GetCloudPrintProxyService();

+ if (service)

+ service->RefreshStatusFromService();

}

CloudPrintProxyService* LocalDiscoveryUIHandler::GetCloudPrintProxyService() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »