Allow dumping raw json fetched from the server.

Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list of snippets was truncated to max_length before deleting outdated snippets - sometimes resulting in less snippets.

BUG=607518
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e
Cr-Commit-Position: refs/heads/master@{#390905}

[jkrcal, 2016-04-29 09:27:42]

Description was changed from

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

BUG=607518
==========

to

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list
of snippets was truncated to max_length before deleting outdated snippets -
sometimes resulting in less snippets.

BUG=607518
==========

[jkrcal, 2016-04-29 09:31:04]

jkrcal@chromium.org changed reviewers:
+ bauerb@chromium.org

[jkrcal, 2016-04-29 09:31:04]

PTAL

[Bernhard Bauer, 2016-04-29 12:02:22]

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:75: if
(dump_current_fetch_) {
If we have the last downloaded JSON anyway, we could always send it to the UI
(maybe in an expandable view) instead of having to do this during a refresh. I
would also consider downloading it as a file to be an additional feature (I
personally wouldn't see that much use for it, but maybe someone else would).

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.h (right):

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.h:57: // Should the
current fetching request be dumped to a file as well?
Nit: empty line before comments.

[jkrcal, 2016-04-29 13:11:48]

Thanks for the comments. Please take a look again.

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:75: if
(dump_current_fetch_) {
On 2016/04/29 12:02:22, Bernhard Bauer wrote:
> If we have the last downloaded JSON anyway, we could always send it to the UI
> (maybe in an expandable view) instead of having to do this during a refresh. I
> would also consider downloading it as a file to be an additional feature (I
> personally wouldn't see that much use for it, but maybe someone else would).

Done, with an extra download button.
Did not format the json in any way, hope it is enough this way.

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.h (right):

https://codereview.chromium.org/1927993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.h:57: // Should the
current fetching request be dumped to a file as well?
On 2016/04/29 12:02:22, Bernhard Bauer wrote:
> Nit: empty line before comments.

Deleted the member :)

[Bernhard Bauer, 2016-04-29 15:10:48]

lgtm

https://codereview.chromium.org/1927993002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/snippets_internals.html (right):

https://codereview.chromium.org/1927993002/diff/40001/chrome/browser/resource...
chrome/browser/resources/snippets_internals.html:82: <h2>Last json</h2>
Nit: JSON in caps

[jkrcal, 2016-05-02 08:20:46]

Description was changed from

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list
of snippets was truncated to max_length before deleting outdated snippets -
sometimes resulting in less snippets.

BUG=607518
==========

to

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list
of snippets was truncated to max_length before deleting outdated snippets -
sometimes resulting in less snippets.

BUG=607518
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jkrcal, 2016-05-02 08:21:01]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-05-02 08:21:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1927993002/#ps60001
(title: "After code review #2")

[commit-bot: I haz the power, 2016-05-02 08:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927993002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927993002/60001

[commit-bot: I haz the power, 2016-05-02 09:14:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-02 09:15:31]

Description was changed from

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list
of snippets was truncated to max_length before deleting outdated snippets -
sometimes resulting in less snippets.

BUG=607518
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list
of snippets was truncated to max_length before deleting outdated snippets -
sometimes resulting in less snippets.

BUG=607518
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e
Cr-Commit-Position: refs/heads/master@{#390905}
==========

[commit-bot: I haz the power, 2016-05-02 09:15:32]

Patchset 4 (id:??) landed as
https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e
Cr-Commit-Position: refs/heads/master@{#390905}