Allow dumping raw json fetched from the server.

chrome/browser/ui/webui/snippets_internals_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>
 #include <vector>
 
@@ skipping 41 matching lines @@
     entry->SetString("id", "snippet-" + base::IntToString(index));
 
   return entry;
 }
 
 } // namespace
 
 SnippetsInternalsMessageHandler::SnippetsInternalsMessageHandler()
     : observer_(this),
       dom_loaded_(false),
+      dump_current_fetch_(false),
       ntp_snippets_service_(nullptr) {}
 
 SnippetsInternalsMessageHandler::~SnippetsInternalsMessageHandler() {}
 
 void SnippetsInternalsMessageHandler::NTPSnippetsServiceShutdown() {}
 
 void SnippetsInternalsMessageHandler::NTPSnippetsServiceLoaded() {
   if (!dom_loaded_) return;
 
   SendSnippets();
   SendDiscardedSnippets();
+
+  if (dump_current_fetch_) {

[Bernhard Bauer, 2016/04/29 12:02:22]

If we have the last downloaded JSON anyway, we could always send it to the UI
(maybe in an expandable view) instead of having to do this during a refresh. I
would also consider downloading it as a file to be an additional feature (I
personally wouldn't see that much use for it, but maybe someone else would).

[jkrcal, 2016/04/29 13:11:48]

Done, with an extra download button.
Did not format the json in any way, hope it is enough this way.

+    SendJson(ntp_snippets_service_->last_json());
+    dump_current_fetch_ = false;
+  }
 }
 
 void SnippetsInternalsMessageHandler::RegisterMessages() {
   // additional initialization (web_ui() does not work from the constructor)
   ntp_snippets_service_ = NTPSnippetsServiceFactory::GetInstance()->
       GetForProfile(Profile::FromWebUI(web_ui()));
   observer_.Add(ntp_snippets_service_);
 
   web_ui()->RegisterMessageCallback(
       "loaded",
@@ skipping 35 matching lines @@
 
 void SnippetsInternalsMessageHandler::HandleDump(const base::ListValue* args) {
   DCHECK_EQ(0u, args->GetSize());
 
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
 
   std::string json;
   base::JSONWriter::Write(
       *pref_service->GetList(ntp_snippets::prefs::kSnippets), &json);
 
-  web_ui()->CallJavascriptFunction("chrome.SnippetsInternals.receiveJson",
-                                   base::StringValue(json));
+  SendJson(json);
 }
 
 void SnippetsInternalsMessageHandler::HandleClearDiscarded(
     const base::ListValue* args) {
   DCHECK_EQ(0u, args->GetSize());
 
   ntp_snippets_service_->ClearDiscardedSnippets();
   SendDiscardedSnippets();
 }
 
 void SnippetsInternalsMessageHandler::HandleDownload(
     const base::ListValue* args) {
-  DCHECK_EQ(1u, args->GetSize());
+  DCHECK_EQ(2u, args->GetSize());
 
   SendString("hosts-status", std::string());
 
   std::string hosts_string;
   args->GetString(0, &hosts_string);
+  args->GetBoolean(1, &dump_current_fetch_);
 
   std::vector<std::string> hosts_vector = base::SplitString(
       hosts_string, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
   std::set<std::string> hosts(hosts_vector.begin(), hosts_vector.end());
 
   ntp_snippets_service_->FetchSnippetsFromHosts(hosts);
 }
 
 void SnippetsInternalsMessageHandler::SendInitialData() {
   SendHosts();
@@ skipping 53 matching lines @@
 
     hosts_list->Append(std::move(entry));
   }
 
   base::DictionaryValue result;
   result.Set("list", std::move(hosts_list));
   web_ui()->CallJavascriptFunction("chrome.SnippetsInternals.receiveHosts",
                                    result);
 }
 
+void SnippetsInternalsMessageHandler::SendJson(const std::string& json) {
+  web_ui()->CallJavascriptFunction("chrome.SnippetsInternals.receiveJson",
+                                   base::StringValue(json));
+}
+
 void SnippetsInternalsMessageHandler::SendBoolean(const std::string& name,
                                                   bool value) {
   SendString(name, value ? "True" : "False");
 }
 
 void SnippetsInternalsMessageHandler::SendString(const std::string& name,
                                                  const std::string& value) {
   base::StringValue string_name(name);
   base::StringValue string_value(value);
 
   web_ui()->CallJavascriptFunction("chrome.SnippetsInternals.receiveProperty",
                                    string_name, string_value);
 }