Unify DescriptorPools for vulkan uniform descriptor sets

Unify DescriptorPools for vulkan uniform descriptor sets

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927943002

Committed: https://skia.googlesource.com/skia/+/778555cfda267eee031b9fc8530f988cd270fbf0

[egdaniel, 2016-04-28 13:03:46]

Description was changed from

==========
Unify DescriptorPools for vulkan uniform descriptor sets

BUG=skia:
==========

to

==========
Unify DescriptorPools for vulkan uniform descriptor sets

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-04-28 13:21:10]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-04-28 13:21:13]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2016-04-28 14:16:12]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-04-28 17:37:21]

Okay this CL is now ready for review

[jvanverth1, 2016-04-28 20:34:30]

lgtm + comments

https://codereview.chromium.org/1927943002/diff/60001/src/gpu/vk/GrVkResource...
File src/gpu/vk/GrVkResourceProvider.cpp (right):

https://codereview.chromium.org/1927943002/diff/60001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResourceProvider.cpp:64: fCurrMaxUniDescriptors = 16;
Add this as a constant.

https://codereview.chromium.org/1927943002/diff/60001/src/gpu/vk/GrVkResource...
File src/gpu/vk/GrVkResourceProvider.h (right):

https://codereview.chromium.org/1927943002/diff/60001/src/gpu/vk/GrVkResource...
src/gpu/vk/GrVkResourceProvider.h:165: static const int   kMaxUniformDescriptors
= 1024;
I believe that Chrome would prefer that these be enums rather than initialized
in the header. See the "static const members vs enums" discussion in
chromium-dev.

[egdaniel, 2016-05-02 13:37:49]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-05-02 13:37:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1927943002/#ps80001
(title: "use enum")

[commit-bot: I haz the power, 2016-05-02 13:38:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927943002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927943002/80001

[commit-bot: I haz the power, 2016-05-02 13:50:38]

Description was changed from

==========
Unify DescriptorPools for vulkan uniform descriptor sets

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Unify DescriptorPools for vulkan uniform descriptor sets

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/778555cfda267eee031b9fc8530f988cd270fbf0
==========

[commit-bot: I haz the power, 2016-05-02 13:50:39]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/778555cfda267eee031b9fc8530f988cd270fbf0