[chrome.displaySource] Avoid compiler warning.

[chrome.displaySource] Avoid compiler warning.

Avoid warnings about unreachable codes, false warnings about potentially
uninitialized variables, warnings about unused local objects related
static functions and signedness warnings.

BUG=242107
Committed: https://crrev.com/045d73f59eabda62850bb1005ed0fbc8fdfe597d
Cr-Commit-Position: refs/heads/master@{#390363}

[e_hakkinen, 2016-04-28 12:45:31]

eero.hakkinen@intel.com changed reviewers:
+ alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com

[e_hakkinen, 2016-04-28 12:45:32]

PTAL.

Tested:
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
File extensions/renderer/api/display_source/display_source_session.cc (left):

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/display_source_session.cc:44: return
nullptr;
Unreachable code.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc
(left):

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc:172:
enum { kInvalidBase = ~static_cast<uint64_t>(0u) };
Causes signedness errors. kInvalidBase might result in being int128_t or
something.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc:563:
WiFiDisplayElementaryStreamPacketizer packetizer;
Object not used for anything but calling a static function.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc:675:
WiFiDisplayElementaryStreamPacketizer elementary_stream_packetizer;
Ditto.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer_unittest.cc:786:
uint16_t sequence_number;
MSVC thinks that the variable is used without initialization.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc
(left):

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc:463:
WiFiDisplayElementaryStreamPacketizer elementary_stream_packetizer;
Object not used for anything but calling a static function.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc:485:
//        - Decoding time stamp
The above detailed list is out-dated and incomplete.
Also, the purpose of WiFiDisplayElementaryStreamPacketizer is that
WiFiDisplayTransportStreamPacketizer does not have to know the details of
elementary stream packetization so let's just remove the list from here.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc
(right):

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc:480:
//  * Elementary stream packet unit header (only for the first packet)
Unit header was not listed in comment.

https://codereview.chromium.org/1927923002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc:482:
size_t header_min_size = 0u;
MSVC thinks that the variable is used without initialization.

[Mikhail, 2016-04-28 12:51:40]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-04-28 12:51:41]

lgtm

[commit-bot: I haz the power, 2016-04-28 12:51:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927923002/1

[commit-bot: I haz the power, 2016-04-28 13:39:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:17:58]

Patchset 1 (id:??) landed as
https://crrev.com/045d73f59eabda62850bb1005ed0fbc8fdfe597d
Cr-Commit-Position: refs/heads/master@{#390363}

[commit-bot: I haz the power, 2016-04-30 17:55:28]

Description was changed from

==========
[chrome.displaySource] Avoid compiler warning.

Avoid warnings about unreachable codes, false warnings about potentially
uninitialized variables, warnings about unused local objects related
static functions and signedness warnings.

BUG=242107
==========

to

==========
[chrome.displaySource] Avoid compiler warning.

Avoid warnings about unreachable codes, false warnings about potentially
uninitialized variables, warnings about unused local objects related
static functions and signedness warnings.

BUG=242107

Committed: https://crrev.com/045d73f59eabda62850bb1005ed0fbc8fdfe597d
Cr-Commit-Position: refs/heads/master@{#390363}
==========