Chromium Code Reviews| Index: extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc |
| diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc b/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc |
| index 6c1917eb28b79ab255d90401556e79b113f056d7..22e1bcfa9a5375fc4fe412473647533a8ec6b6c7 100644 |
| --- a/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc |
| +++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.cc |
| @@ -460,9 +460,8 @@ bool WiFiDisplayTransportStreamPacketizer::EncodeElementaryStreamUnit( |
| UpdateDelayForUnitTimeStamps(pts, dts); |
| NormalizeUnitTimeStamps(&pts, &dts); |
| - WiFiDisplayElementaryStreamPacketizer elementary_stream_packetizer; |
|
e_hakkinen
2016/04/28 12:45:32
Object not used for anything but calling a static
|
| WiFiDisplayElementaryStreamPacket elementary_stream_packet = |
| - elementary_stream_packetizer.EncodeElementaryStreamUnit( |
| + WiFiDisplayElementaryStreamPacketizer::EncodeElementaryStreamUnit( |
| stream_state.stream_id, stream_state.unit_header.data, |
| stream_state.unit_header.size, unit_data, unit_size, pts, dts); |
| @@ -477,14 +476,10 @@ bool WiFiDisplayTransportStreamPacketizer::EncodeElementaryStreamUnit( |
| // (only for the first and/or the last packet): |
| // - for the first packet to hold flags |
| // - for the last packet to hold padding |
| - // * PES packet header (only for the first packet): |
| - // - PES packet header base |
| - // - Optional PES header base |
| - // - Optional PES header optional fields: |
| - // - Presentation time stamp |
| - // - Decoding time stamp |
|
e_hakkinen
2016/04/28 12:45:32
The above detailed list is out-dated and incomplet
|
| + // * Elementary stream packet header (only for the first packet) |
| + // * Elementary stream packet unit header (only for the first packet) |
|
e_hakkinen
2016/04/28 12:45:32
Unit header was not listed in comment.
|
| bool adaptation_field_flag = false; |
| - size_t header_min_size; |
| + size_t header_min_size = 0u; |
|
e_hakkinen
2016/04/28 12:45:32
MSVC thinks that the variable is used without init
|
| const bool is_payload_unit_start_or_end = |
| is_payload_unit_start || |
| remaining_unit_size <= WiFiDisplayTransportStreamPacket::kPacketSize - |