[Media, UI] Don't record click UMA when content intent is null

[Media, UI] Don't record click UMA when content intent is null

BUG=607397
Committed: https://crrev.com/cc3af8b9fe9c368d9046f3a19d64cb8aaa4490b5
Cr-Commit-Position: refs/heads/master@{#390351}

[Zhiqiang Zhang (Slow), 2016-04-28 10:33:55]

zqzhang@chromium.org changed reviewers:
+ aberent@chromium.org, mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-04-28 10:33:56]

aberent@chromium.org: Please review changes in 
CastNotificationControl.java

mlamouri@chromium.org: Please review changes in 
MediaSessionTabHelper.java
CastSessionImpl.java

[Zhiqiang Zhang (Slow), 2016-04-28 10:35:14]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 10:35:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927863003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927863003/1

[mlamouri (slow - plz ping), 2016-04-28 10:58:02]

lgtm

[commit-bot: I haz the power, 2016-04-28 11:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 11:09:13]

Dry run: This issue passed the CQ dry run.

[aberent, 2016-04-28 11:19:08]

https://codereview.chromium.org/1927863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
(right):

https://codereview.chromium.org/1927863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:104:
if (contentIntent != null) {
|contentIntent| is the result of a new call, so can never be null. See
http://stackoverflow.com/questions/11103444/can-constructor-return-a-null-object.
As such this change is unnecessary.

[Zhiqiang Zhang (Slow), 2016-04-28 11:20:59]

https://codereview.chromium.org/1927863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
(right):

https://codereview.chromium.org/1927863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:104:
if (contentIntent != null) {
On 2016/04/28 11:19:08, aberent wrote:
> |contentIntent| is the result of a new call, so can never be null. See
>
http://stackoverflow.com/questions/11103444/can-constructor-return-a-null-object.
> As such this change is unnecessary.

Oops, this is not a BringTabToFrontIntent. Will undo this change. Thanks!

[Zhiqiang Zhang (Slow), 2016-04-28 11:40:13]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-04-28 11:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1927863003/#ps20001
(title: "undo changes in CastNotificationControl.java")

[commit-bot: I haz the power, 2016-04-28 11:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927863003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927863003/20001

[commit-bot: I haz the power, 2016-04-28 12:14:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:17:37]

Patchset 2 (id:??) landed as
https://crrev.com/cc3af8b9fe9c368d9046f3a19d64cb8aaa4490b5
Cr-Commit-Position: refs/heads/master@{#390351}

[commit-bot: I haz the power, 2016-04-30 17:55:14]

Description was changed from

==========
[Media, UI] Don't record click UMA when content intent is null

BUG=607397
==========

to

==========
[Media, UI] Don't record click UMA when content intent is null

BUG=607397

Committed: https://crrev.com/cc3af8b9fe9c368d9046f3a19d64cb8aaa4490b5
Cr-Commit-Position: refs/heads/master@{#390351}
==========