chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java - Issue 1927863003: [Media, UI] Don't record click UMA when content intent is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

Issue 1927863003: [Media, UI] Don't record click UMA when content intent is null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: undo changes in CastNotificationControl.java Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

index 01aff0f520427a5f498a5d3a266d9f428d2d7e83..cef866a6d2c32bf2e23608ca74948cfe1e29abd0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

@@ -142,8 +142,10 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {

}

Intent contentIntent = Tab.createBringTabToFrontIntent(tabId);

- contentIntent.putExtra(MediaNotificationUma.INTENT_EXTRA_NAME,

- MediaNotificationUma.SOURCE_PRESENTATION);

+ if (contentIntent != null) {

+ contentIntent.putExtra(MediaNotificationUma.INTENT_EXTRA_NAME,

+ MediaNotificationUma.SOURCE_PRESENTATION);

+ }

mNotificationBuilder = new MediaNotificationInfo.Builder()

.setPaused(false)

.setOrigin(origin)

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java » ('j') | no next file with comments »