Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 19278016: Add load states for stalled requests (Closed)

Created:
7 years, 5 months ago by mmenke
Modified:
7 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, creis+watch_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org
Visibility:
Public.

Description

Add load states for requests stalled waiting for a socket slot in socket pools / socket pool groups. This is intended to make it easier to identify issues where something is holding on to sockets and not releasing them, as is the case in two of the referenced bugs. Also helpful to identify proxy issues where the global socket pool limit is reached. Bug=241844, 233181, 248412 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212739

Patch Set 1 #

Patch Set 2 : Use one string for both states #

Patch Set 3 : Work on tests a little #

Total comments: 2

Patch Set 4 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -51 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/load_states_list.h View 1 chunk +11 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 2 1 chunk +19 lines, -17 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 3 10 chunks +180 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mmenke
Old CL from a while back. Stalled on figuring out what string to use for ...
7 years, 5 months ago (2013-07-16 19:32:18 UTC) #1
eroman
lgtm https://codereview.chromium.org/19278016/diff/26001/net/socket/client_socket_pool_base_unittest.cc File net/socket/client_socket_pool_base_unittest.cc (right): https://codereview.chromium.org/19278016/diff/26001/net/socket/client_socket_pool_base_unittest.cc#newcode1948 net/socket/client_socket_pool_base_unittest.cc:1948: // Test GetLoadState in the case there's two ...
7 years, 5 months ago (2013-07-16 21:41:02 UTC) #2
mmenke
https://codereview.chromium.org/19278016/diff/26001/net/socket/client_socket_pool_base_unittest.cc File net/socket/client_socket_pool_base_unittest.cc (right): https://codereview.chromium.org/19278016/diff/26001/net/socket/client_socket_pool_base_unittest.cc#newcode1948 net/socket/client_socket_pool_base_unittest.cc:1948: // Test GetLoadState in the case there's two socket ...
7 years, 5 months ago (2013-07-17 14:43:05 UTC) #3
mmenke
[+avi]: Please do an OWNERs review of the changes to chrome/browser/ui/tab_contents/core_tab_helper.cc. The new state should ...
7 years, 5 months ago (2013-07-17 14:51:18 UTC) #4
mmenke
Looks like avi is now on vacation. [+jam]: Please do an OWNERs review of the ...
7 years, 5 months ago (2013-07-19 15:08:54 UTC) #5
jam
On 2013/07/19 15:08:54, mmenke wrote: > Looks like avi is now on vacation. > > ...
7 years, 5 months ago (2013-07-19 20:44:15 UTC) #6
mmenke
On 2013/07/19 20:44:15, jam wrote: > On 2013/07/19 15:08:54, mmenke wrote: > > Looks like ...
7 years, 5 months ago (2013-07-19 20:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/19278016/33001
7 years, 5 months ago (2013-07-19 20:49:36 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-20 04:38:56 UTC) #9
Message was sent while issue was closed.
Change committed as 212739

Powered by Google App Engine
This is Rietveld 408576698