Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 192773002: Fix assertion in RegExp parser to correctly expect stack overflow. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Fix assertion in RegExp parser to correctly expect stack overflow. Advance() always checks for stack overflow. If stack indeed overflowed, current() would hold the kEndMarker. ParseOctalLiteral does not expect this in the assertion, which causes assertion failure. R=mvstanton@chromium.org BUG=350865 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-350865.js View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 9 months ago (2014-03-10 14:01:52 UTC) #1
mvstanton
lgtm
6 years, 9 months ago (2014-03-10 15:49:19 UTC) #2
Yang
6 years, 9 months ago (2014-03-10 15:52:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698