src/parser.cc - Issue 192773002: Fix assertion in RegExp parser to correctly expect stack overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 192773002: Fix assertion in RegExp parser to correctly expect stack overflow. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 9b8223c7558e5b9217ece0ab67c331e6d717206b..cf417b8c64c905c1f50c52329aa2de915446f327 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4990,7 +4990,7 @@ bool RegExpParser::ParseIntervalQuantifier(int* min_out, int* max_out) {

uc32 RegExpParser::ParseOctalLiteral() {

- ASSERT('0' <= current() && current() <= '7');

+ ASSERT(('0' <= current() && current() <= '7') || current() == kEndMarker);

// For compatibility with some other browsers (not all), we parse

// up to three octal digits with a value below 256.

uc32 value = current() - '0';

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-350865.js » ('j') | no next file with comments »