Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: testing/tools/pngdiffer.py

Issue 1927633002: Remove output redirect from corpus test runner. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/tools/common.py ('k') | testing/tools/run_corpus_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/tools/pngdiffer.py
diff --git a/testing/tools/pngdiffer.py b/testing/tools/pngdiffer.py
index 79d1b7588a7eeda4df99bc3caa341687e8081954..a1533b8329f4a440e5cee836ed3f0fee000d673c 100755
--- a/testing/tools/pngdiffer.py
+++ b/testing/tools/pngdiffer.py
@@ -38,8 +38,7 @@ class PNGDiffer():
i += 1
return actual_paths
- def HasDifferences(self, input_filename, source_dir, working_dir,
- redirect_output=False):
+ def HasDifferences(self, input_filename, source_dir, working_dir):
template_paths = self._GetTemplatePaths(
input_filename, source_dir, working_dir)
actual_path_template = template_paths[0];
@@ -62,16 +61,14 @@ class PNGDiffer():
sys.stdout.flush()
if os.path.exists(expected_path):
error = common.RunCommand(
- [self.pdfium_diff_path, expected_path, actual_path],
- redirect_output)
+ [self.pdfium_diff_path, expected_path, actual_path])
else:
error = 1;
if error:
# When failed, we check against platform based results.
if os.path.exists(platform_expected_path):
error = common.RunCommand(
- [self.pdfium_diff_path, platform_expected_path, actual_path],
- redirect_output)
+ [self.pdfium_diff_path, platform_expected_path, actual_path])
if error:
print "FAILURE: " + input_filename + "; " + str(error)
return True
« no previous file with comments | « testing/tools/common.py ('k') | testing/tools/run_corpus_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698