Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: testing/tools/common.py

Issue 1927633002: Remove output redirect from corpus test runner. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/tools/pngdiffer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/tools/common.py
diff --git a/testing/tools/common.py b/testing/tools/common.py
index 6e9de7c82c67828a012a96b90d800e0152375bd9..1e1d257f48d608eb33845e9877b588442577e118 100755
--- a/testing/tools/common.py
+++ b/testing/tools/common.py
@@ -18,12 +18,9 @@ def os_name():
raise Exception('Confused, can not determine OS, aborting.')
-def RunCommand(cmd, redirect_output=False):
+def RunCommand(cmd):
try:
- if redirect_output:
- sys.stdout.write(subprocess.check_output(cmd, stderr=subprocess.STDOUT))
- else:
- subprocess.check_call(cmd)
+ subprocess.check_call(cmd)
return None
except subprocess.CalledProcessError as e:
return e
« no previous file with comments | « no previous file | testing/tools/pngdiffer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698