Add a PhysicalWebEnvironment class

Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}

Committed: https://crrev.com/4d8ccd8392faa23539f84ca5abcf6e6a0fea7450
Cr-Commit-Position: refs/heads/master@{#391699}

[mattreynolds, 2016-04-27 21:42:08]

mattreynolds@chromium.org changed reviewers:
+ nyquist@chromium.org

[mattreynolds, 2016-04-27 21:42:09]

Hi Tommy, PTAL.

This is the first of two CLs to add support for the Discoverer flag that will
turn off our Physical Web notifications when Discoverer is showing its own
notifications.  The internal CL needs to land after this one and is linked from
the bug.

I recreated this CL from cco3's original:
https://codereview.chromium.org/1902593002/ (is there a better way to transfer
CL ownership in Rietveld?)

[nyquist, 2016-04-27 21:46:29]

https://codereview.chromium.org/1927593004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java
(right):

https://codereview.chromium.org/1927593004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java:21:
public static PhysicalWebEnvironment getInstance(ChromeApplication
chromeApplication) {
Should you add ThreadUtils.assertOnUiThread() here to ensure there will be no
issues in the future regarding threading?

[mattreynolds, 2016-04-27 22:09:34]

https://codereview.chromium.org/1927593004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java
(right):

https://codereview.chromium.org/1927593004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java:21:
public static PhysicalWebEnvironment getInstance(ChromeApplication
chromeApplication) {
On 2016/04/27 21:46:28, nyquist wrote:
> Should you add ThreadUtils.assertOnUiThread() here to ensure there will be no
> issues in the future regarding threading?

Good call, done

[nyquist, 2016-04-27 22:21:33]

lgtm

[mattreynolds, 2016-04-27 22:22:10]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:22:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/20001

[commit-bot: I haz the power, 2016-04-27 22:51:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:51:42]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[mattreynolds, 2016-04-27 23:31:26]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-04-27 23:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1927593004/#ps40001
(title: "register new file in java_sources.gni")

[commit-bot: I haz the power, 2016-04-27 23:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/40001

[commit-bot: I haz the power, 2016-04-28 00:30:35]

Committed patchset #3 (id:40001)

[Justin Donnelly, 2016-04-28 03:26:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1928443005/ by jdonnelly@chromium.org.

The reason for reverting is: Broke the Android GN builder:

https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34011.

[Justin Donnelly, 2016-04-28 03:29:13]

On 2016/04/28 03:26:29, Justin Donnelly wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1928443005/ by mailto:jdonnelly@chromium.org.
> 
> The reason for reverting is: Broke the Android GN builder:
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34011.

Also the Android Tests (dbg) bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

[mattreynolds, 2016-04-29 19:14:57]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
==========

[mattreynolds, 2016-04-29 19:17:22]

On 2016/04/28 03:29:13, Justin Donnelly wrote:
> On 2016/04/28 03:26:29, Justin Donnelly wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/1928443005/ by
mailto:jdonnelly@chromium.org.
> > 
> > The reason for reverting is: Broke the Android GN builder:
> > 
> >
>
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34011.
> 
> Also the Android Tests (dbg) bot:
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

In those logs I only see failures from our tests.  Both tests passed with this
change when I ran them locally.

[mattreynolds, 2016-04-29 19:17:37]

The CQ bit was checked by mattreynolds@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 19:18:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/40001

[commit-bot: I haz the power, 2016-04-29 20:20:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 20:20:06]

Dry run: This issue passed the CQ dry run.

[mattreynolds, 2016-04-29 20:21:22]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2016-04-29 20:21:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/40001

[commit-bot: I haz the power, 2016-04-29 20:27:14]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
==========

[commit-bot: I haz the power, 2016-04-29 20:27:15]

Committed patchset #3 (id:40001)

[mattreynolds, 2016-04-29 22:18:56]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1942463002/ by mattreynolds@chromium.org.

The reason for reverting is: Broke the GN build again (test failures):

https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34043

Instrumentation test ChromePublicTest 
failures:
org.chromium.chrome.browser.physicalweb.ListUrlsActivityTest#testUrlsListEmptyInOnboarding
org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlWhileOnboardingMakesNotification.

[commit-bot: I haz the power, 2016-04-30 17:14:58]

Patchset 3 (id:??) landed as
https://crrev.com/77fa2b353cf3cca85eebe8e36dd345ed1a35af65
Cr-Commit-Position: refs/heads/master@{#390254}

[commit-bot: I haz the power, 2016-04-30 17:28:24]

Patchset 3 (id:??) landed as
https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}

[commit-bot: I haz the power, 2016-04-30 17:53:19]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/77fa2b353cf3cca85eebe8e36dd345ed1a35af65
Cr-Commit-Position: refs/heads/master@{#390254}
==========

[commit-bot: I haz the power, 2016-04-30 18:02:14]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/77fa2b353cf3cca85eebe8e36dd345ed1a35af65
Cr-Commit-Position: refs/heads/master@{#390254}
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

[mattreynolds, 2016-05-03 23:10:11]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

[mattreynolds, 2016-05-03 23:11:24]

The tests that were failing have been disabled
(https://codereview.chromium.org/1937643002/) so let's try it again.

[mattreynolds, 2016-05-03 23:11:31]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2016-05-03 23:12:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/40001

[commit-bot: I haz the power, 2016-05-04 00:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:24:04]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-05-04 00:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[mattreynolds, 2016-05-04 22:29:40]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-05-04 22:29:41]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1927593004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-04 22:30:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927593004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927593004/60001

[commit-bot: I haz the power, 2016-05-04 23:56:46]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

[commit-bot: I haz the power, 2016-05-04 23:56:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-04 23:58:27]

Description was changed from

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}
==========

to

==========
Add a PhysicalWebEnvironment class

This class has a hasNotificationBasedClient method that will
allow us to disable notifications if there is another Physical Web
client showing notifications.

BUG=604502

Committed: https://crrev.com/e4eeab705b90400e255496cf7ccf85ef62e24809
Cr-Commit-Position: refs/heads/master@{#390739}

Committed: https://crrev.com/4d8ccd8392faa23539f84ca5abcf6e6a0fea7450
Cr-Commit-Position: refs/heads/master@{#391699}
==========

[commit-bot: I haz the power, 2016-05-04 23:58:28]

Patchset 4 (id:??) landed as
https://crrev.com/4d8ccd8392faa23539f84ca5abcf6e6a0fea7450
Cr-Commit-Position: refs/heads/master@{#391699}