chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java - Issue 1927593004: Add a PhysicalWebEnvironment class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 1927593004: Add a PhysicalWebEnvironment class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

index 5123e7bf6f0e2bb648373acf936736e8f2e683fa..5ac519cdd00144b96a6f40116a074ebb3d51d270 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

@@ -25,6 +25,7 @@ import org.chromium.base.Log;

import org.chromium.base.ObserverList;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationManagerProxy;

import org.chromium.chrome.browser.notifications.NotificationManagerProxyImpl;

@@ -415,6 +416,13 @@ class UrlManager {

return;

}

+ // We should only show notifications if there's no other notification-based client.

+ if (PhysicalWebEnvironment

+ .getInstance((ChromeApplication) mContext.getApplicationContext())

+ .hasNotificationBasedClient()) {

+ return;

+ }

// We only call showNotification if the list was empty before because we need to be able to

// count the number of times we show the OptIn notification.

if (isUrlListEmptyBefore) {