Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
DOCS_PREVIEW= https://skia.org/?cl=1927583002

Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db

[djsollen, 2016-04-27 13:53:00]

Description was changed from

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
==========

to

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1927583002
==========

[djsollen, 2016-04-27 13:53:25]

The CQ bit was checked by djsollen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 13:53:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927583002/1

[commit-bot: I haz the power, 2016-04-27 14:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:00:18]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[djsollen, 2016-04-27 17:09:26]

djsollen@google.com changed reviewers:
+ bungeman@gmail.com, reed@google.com

[bungeman-skia, 2016-04-27 18:22:02]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-04-27 18:22:03]

I love it, lgtm with one doc nit

https://codereview.chromium.org/1927583002/diff/1/site/dev/runtime/index.md
File site/dev/runtime/index.md (right):

https://codereview.chromium.org/1927583002/diff/1/site/dev/runtime/index.md#n...
site/dev/runtime/index.md:158: int turn enables runtime configuration behavior.
nit: s/int/in

[djsollen, 2016-04-27 20:23:23]

The CQ bit was checked by djsollen@google.com

[djsollen, 2016-04-27 20:23:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1927583002/#ps20001
(title: "fix typo")

[commit-bot: I haz the power, 2016-04-27 20:23:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1927583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1927583002/20001

[commit-bot: I haz the power, 2016-04-27 20:37:25]

Description was changed from

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1927583002
==========

to

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1927583002

Committed:
https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db
==========

[commit-bot: I haz the power, 2016-04-27 20:37:26]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db

[dogben, 2016-04-28 01:02:30]

benjaminwagner@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2016-04-28 01:02:31]

https://codereview.chromium.org/1927583002/diff/20001/src/core/SkResourceCach...
File src/core/SkResourceCache.cpp (right):

https://codereview.chromium.org/1927583002/diff/20001/src/core/SkResourceCach...
src/core/SkResourceCache.cpp:552: #if SK_DEBUG
I think this needs to be #ifdef rather than #if.

[reed1, 2016-04-28 15:12:37]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1918253006/ by reed@google.com.

The reason for reverting is: still blocking DEPS roll.