Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: site/dev/runtime/index.md

Issue 1927583002: Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix typo Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: site/dev/runtime/index.md
diff --git a/site/dev/runtime/index.md b/site/dev/runtime/index.md
index b7e656b29f0864c5a3e42841ead6c47d438c5bdd..7c8246d23f12865dda6049bf2d0e5b6976cb3dc3 100644
--- a/site/dev/runtime/index.md
+++ b/site/dev/runtime/index.md
@@ -152,11 +152,10 @@ options.
## Are these things enabled all the time?
-In `Debug` builds, yes. `Release` builds disable runtime configuration by
-default, but it is still useful to be able to tweak certain algorithm parameters
-at runtime to do scripted performance studies. Therefore, a third build type,
-`Release_Developer` has been added. This build type has exactly the same build
-flags as `Release`, except it re-enables all runtime configuration behavior.
+No, they are only enabled in builds where SK_DEBUG is defined. This includes both
+`Debug` and `Release_Developer` gyp BUILDTYPES. The `Release_Developer` build type
+has exactly the same build flags as `Release`, except it re-enables SK_DEBUG, which
+in turn enables runtime configuration behavior.
Specifically:
<!--?prettify?-->
@@ -180,7 +179,3 @@ Runtime configuration variables of type `char \* ` cannot currently have spaces
in them.
Runtime variables are only fully supported for `int`, `unsigned int`, `float`,
`double`, `bool`, and `char \*`.
-
-## Questions? Bugs? Improvements?
-
-Feel free to send feedback on this system to Greg Humphreys \(humper@google\.com\)
« no previous file with comments | « include/utils/SkRTConf.h ('k') | src/core/SkClipStack.cpp » ('j') | src/core/SkResourceCache.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698