Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java

Issue 1927543003: Remove DrawGLFunctor CleanupReference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java b/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
index 9192b340ddba0c79bacdb8811d4b344c961ab1a8..4dc44c378e05e38487c894daf37a0b18dd7973fb 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/DrawGLFunctor.java
@@ -11,7 +11,6 @@ import android.view.View;
import com.android.webview.chromium.WebViewDelegateFactory.WebViewDelegate;
import org.chromium.android_webview.AwContents;
-import org.chromium.content.common.CleanupReference;
/**
* Simple Java abstraction and wrapper for the native DrawGLFunctor flow.
@@ -23,13 +22,11 @@ class DrawGLFunctor implements AwContents.NativeDrawGLFunctor {
private static final String TAG = DrawGLFunctor.class.getSimpleName();
// Pointer to native side instance
- private final CleanupReference mCleanupReference;
private final DestroyRunnable mDestroyRunnable;
private final WebViewDelegate mWebViewDelegate;
public DrawGLFunctor(long viewContext, WebViewDelegate webViewDelegate) {
mDestroyRunnable = new DestroyRunnable(nativeCreateGLFunctor(viewContext));
- mCleanupReference = new CleanupReference(this, mDestroyRunnable);
mWebViewDelegate = webViewDelegate;
}
@@ -72,6 +69,11 @@ class DrawGLFunctor implements AwContents.NativeDrawGLFunctor {
return sSupportFunctorReleasedCallback;
}
+ @Override
+ public Runnable getDestroyRunnable() {
+ return mDestroyRunnable;
boliu 2016/04/27 17:08:46 Assert everywhere mNativeDrawGLFunctor is used tha
+ }
+
public static void setChromiumAwDrawGLFunction(long functionPointer) {
nativeSetChromiumAwDrawGLFunction(functionPointer);
}

Powered by Google App Engine
This is Rietveld 408576698