Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java

Issue 1927543003: Remove DrawGLFunctor CleanupReference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
diff --git a/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java b/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
index d03a662f2fe8f4f70a65b813740cd1770bc0766c..a2dd796ee5af0468b6e4dceab7bdf4c1ab9dd921 100644
--- a/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
+++ b/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
@@ -145,6 +145,7 @@ public class AwTestContainerView extends FrameLayout {
public void requestRender(long viewContext, Canvas canvas, boolean waitForCompletion) {
synchronized (mSyncLock) {
+ assert viewContext != 0;
assert mViewContext == 0 || mViewContext == viewContext;
mViewContext = viewContext;
super.requestRender();
@@ -451,6 +452,16 @@ public class AwTestContainerView extends FrameLayout {
public void detach(View containerView) {
if (isBackedByHardwareView()) mHardwareView.detachGLFunctor();
}
+
+ @Override
+ public Runnable getDestroyRunnable() {
+ return new Runnable() {
boliu 2016/04/27 17:08:46 this needs to be static to make the gc tests pass
Tobias Sargeant 2016/04/27 17:29:49 Acknowledged.
+ @Override
+ public void run() {
+ mContext = 0;
boliu 2016/04/27 17:08:46 maybe assert everywhere mContext is used that it's
Tobias Sargeant 2016/04/27 17:29:49 mContext is passed to requestRender as viewContext
+ }
+ };
+ }
}
// TODO: AwContents could define a generic class that holds an implementation similar to

Powered by Google App Engine
This is Rietveld 408576698