Issue 192743006: MIPS: Reland "Handle non-power-of-2 divisors in division-like operations".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192743006: MIPS: Reland "Handle non-power-of-2 divisors in division-like operations". (Closed)

Created:
6 years, 9 months ago by kilvadyb

Modified:
6 years, 9 months ago

Reviewers:
Benedikt Meurer, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Reland "Handle non-power-of-2 divisors in division-like operations". Port r19749 (4880ed9) Original commit message: Fixed the flooring div bug and added a test case. BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -155 lines)			Patch
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+54 lines, -123 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	3 chunks	+29 lines, -6 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+23 lines, -26 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, I'll fix the nit when landing. As with r19733/r19715, this is a partial port ...

6 years, 9 months ago (2014-03-10 19:45:55 UTC) #2

Committed as r19774.

Expand Messages | Collapse Messages