Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: recipe_modules/tryserver/api.py

Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/tryserver/api.py
diff --git a/recipe_modules/tryserver/api.py b/recipe_modules/tryserver/api.py
index 8bd8df87f94bdfb68e7ad7f91ee0a15f54fec61a..e2088afe8fbfa03858a1e860430cb57efe4d8d22 100644
--- a/recipe_modules/tryserver/api.py
+++ b/recipe_modules/tryserver/api.py
@@ -149,6 +149,8 @@ class TryserverApi(recipe_api.RecipeApi):
pass
def get_files_affected_by_patch(self):
+ # DO NOT USE THIS. Use same method in gclient recipe_module.
+ # TODO(tandrii): remove this method completely.
git_diff_kwargs = {}
issue_root = self.m.rietveld.calculate_issue_root()
if issue_root:
« recipe_modules/gclient/api.py ('K') | « recipe_modules/gclient/example.expected/tryserver_win.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698