Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: recipe_modules/gclient/example.expected/tryserver_win.json

Issue 1927403003: Avoid computing patch_root in get_files_affected_by_patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/gclient/example.expected/tryserver_win.json
diff --git a/recipe_modules/gclient/example.expected/tryserver.json b/recipe_modules/gclient/example.expected/tryserver_win.json
similarity index 74%
copy from recipe_modules/gclient/example.expected/tryserver.json
copy to recipe_modules/gclient/example.expected/tryserver_win.json
index dd0061fe618850881c6eae57a5f3b15b4ba2b86a..3bd0fc9648c3637615856407df6d20649454a738 100644
--- a/recipe_modules/gclient/example.expected/tryserver.json
+++ b/recipe_modules/gclient/example.expected/tryserver_win.json
@@ -3,13 +3,13 @@
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"config",
"--spec",
"cache_dir = '[ROOT]/git_cache'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]"
],
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient setup"
},
@@ -17,12 +17,12 @@
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"sync",
"--verbose",
"--with_branch_heads",
"--nohooks",
- "-j8",
+ "-j2",
"--reset",
"--force",
"--upstream",
@@ -34,7 +34,7 @@
"/path/to/tmp/json"
],
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient sync",
"~followup_annotations": [
@@ -52,7 +52,7 @@
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"recurse",
"git",
"config",
@@ -60,7 +60,7 @@
"local_bot"
],
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient recurse (git config user.name)"
},
@@ -68,7 +68,7 @@
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"recurse",
"git",
"config",
@@ -76,22 +76,44 @@
"local_bot@example.com"
],
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient recurse (git config user.email)"
},
{
"cmd": [
+ "RECIPE_PACKAGE_REPO[depot_tools]\\bootstrap\\win\\win_tools.bat"
+ ],
+ "cwd": "RECIPE_PACKAGE_REPO[depot_tools]",
+ "name": "ensure git tooling on windows"
+ },
+ {
+ "cmd": [
+ "RECIPE_PACKAGE_REPO[depot_tools]\\git.bat",
+ "diff",
+ "--cached",
+ "--name-only"
+ ],
+ "cwd": "[ROOT]\\src",
+ "name": "git diff to analyze patch",
+ "stdout": "/path/to/tmp/",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@files@src/foo.cc@@@",
+ "@@@STEP_LOG_END@files@@@"
+ ]
+ },
+ {
+ "cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"config",
"--spec",
"cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': 'DEPS', 'managed': True, 'name': 'WebKit', 'safesync_url': 'https://blink-status.appspot.com/lkgr', 'url': 'svn://svn.chromium.org/blink/trunk'}]"
],
- "cwd": "[SLAVE_BUILD]/src/third_party",
+ "cwd": "[SLAVE_BUILD]\\src\\third_party",
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "[spec: WebKit] gclient setup"
},
@@ -99,18 +121,18 @@
"cmd": [
"python",
"-u",
- "[BUILD]/scripts/slave/gclient_safe_revert.py",
+ "[BUILD]\\scripts\\slave\\gclient_safe_revert.py",
".",
- "[DEPOT_TOOLS]/gclient"
+ "[DEPOT_TOOLS]\\gclient.bat"
],
- "cwd": "[SLAVE_BUILD]/src/third_party",
+ "cwd": "[SLAVE_BUILD]\\src\\third_party",
"name": "[spec: WebKit] gclient revert"
},
{
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"sync",
"--nohooks",
"--force",
@@ -122,9 +144,9 @@
"--output-json",
"/path/to/tmp/json"
],
- "cwd": "[SLAVE_BUILD]/src/third_party",
+ "cwd": "[SLAVE_BUILD]\\src\\third_party",
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "[spec: WebKit] gclient sync",
"~followup_annotations": [
@@ -169,11 +191,11 @@
"cmd": [
"python",
"-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",
"runhooks"
],
"env": {
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient runhooks"
},

Powered by Google App Engine
This is Rietveld 408576698