Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1927323002: Implement stable resolution of generic types without type arguments to their bounds. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge and regenerate the task graph. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1068 lines, -510 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 4 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/doc/tasks.html View 1 8 chunks +86 lines, -68 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 5 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 3 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 13 chunks +124 lines, -52 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 104 chunks +364 lines, -157 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 69 chunks +276 lines, -145 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +53 lines, -1 line 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 1 8 chunks +86 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-04-28 20:53:56 UTC) #1
Brian Wilkerson
lgtm, although you need to regenerate the task graph.
4 years, 7 months ago (2016-04-28 21:13:52 UTC) #2
scheglov
Committed patchset #2 (id:20001) manually as 0f0b38dab3320ab4b6cf27ac6ffe18d55c2f295e (presubmit successful).
4 years, 7 months ago (2016-04-29 15:26:01 UTC) #4
Leaf
4 years, 7 months ago (2016-04-29 15:36:04 UTC) #5
Message was sent while issue was closed. 
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698